mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 60551: Added a test for docker container running on a v4/6 host network.
Date Wed, 05 Jul 2017 23:53:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60551/#review179729
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4348 (patched)
<https://reviews.apache.org/r/60551/#comment254572>

    You can kill the `;` at the end.



src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4350 (patched)
<https://reviews.apache.org/r/60551/#comment254571>

    You can kill the `;` at the end.



src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4367-4370 (patched)
<https://reviews.apache.org/r/60551/#comment254574>

    What if the host doesn't have both networks? Do we need more checks in place to keep this
from being run on all machines that just have `ROOT_DOCKER`?



src/tests/mesos.hpp
Lines 248 (patched)
<https://reviews.apache.org/r/60551/#comment254567>

    Comment why this class exists.
    
    Also, why doesn't this extend from the test fixture class?
    
    I think we should just factor this into the `DockerContainerizerIPv6Test::SetUp` and `DockerContainerizerIPv6Test::TearDown`
below for now and also add a comment that we eventually want to pull this out into it's own
class.


- Benjamin Hindman


On June 29, 2017, 11:22 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60551/
> -----------------------------------------------------------
> 
> (Updated June 29, 2017, 11:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-7488
>     https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for docker container running on a v4/6 host network.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp cf9470245ebc81e799fb2b2a67464298564fc56f

>   src/tests/mesos.hpp eac2c96985cdbbf1a50cfc054862eae2d44fbfcd 
>   src/tests/mesos.cpp d3e6bc0a92ec9b410712891c6a02d01ed2b587c1 
> 
> 
> Diff: https://reviews.apache.org/r/60551/diff/2/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message