mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.
Date Wed, 05 Jul 2017 23:26:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60580/#review179731
-----------------------------------------------------------



Bad patch!

Reviews applied: [60580]

Failed command: python support/apply-reviews.py -n -r 60580

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in <module>
    main()
  File "support/apply-reviews.py", line 412, in main
    reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
    apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
    fetch_patch(options)
  File "support/apply-reviews.py", line 215, in fetch_patch
    shell(cmd, options['dry_run'])
UnboundLocalError: local variable 'cmd' referenced before assignment

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/125/console

- Mesos Reviewbot Windows


On July 5, 2017, 4:30 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60580/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 4:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filtering to the '/frameworks' endpoint.
> 
> Add query parameter support for '/frameworks' endpoint.
> To query the information about a specific framework, we
> can use 'framework_id' to specify the framework, thus it
> looks like'/frameworks?framework_id=[framework id]'
> 
> To maintain consistency, the structure for response is
> reserved, thus the response still contains field 'frameworks'
> and 'completed_frameworks' etc..
> 
> Since code for '/state' endpoint and '/frameworks' are coupled
> (they share 'FullFrameworkWriter' class), thus the code for '/state'
> endpoint is also updated.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp b7e4a8adcbcaa3a962af795c67694a35161b6c1a 
>   src/common/http.cpp fdb591eccf273260902f3f695cf431f72ee3d817 
>   src/master/http.cpp 64b7cdd1c42a067bf24e302b9496bb75cb916590 
>   src/tests/master_tests.cpp d21194fb19781a24223d6b0d8f99987f4edb5a9a 
> 
> 
> Diff: https://reviews.apache.org/r/60580/diff/2/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> Passed 'GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework"
--gtest_repeat=1000 --gtest_break_on_failure'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message