mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.
Date Wed, 05 Jul 2017 23:21:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60598/#review179730
-----------------------------------------------------------



Bad patch!

Reviews applied: [60598]

Failed command: python support/apply-reviews.py -n -r 60598

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in <module>
    main()
  File "support/apply-reviews.py", line 412, in main
    reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
    apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
    fetch_patch(options)
  File "support/apply-reviews.py", line 215, in fetch_patch
    shell(cmd, options['dry_run'])
UnboundLocalError: local variable 'cmd' referenced before assignment

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/125/console

- Mesos Reviewbot Windows


On July 3, 2017, 2:58 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60598/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 2:58 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and
James Peach.
> 
> 
> Bugs: MESOS-7160
>     https://issues.apache.org/jira/browse/MESOS-7160
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, abort() was called in SUPERVISOR hook when child process
> exited with an error code, or waitpid() failed, or parent process
> exited. All these cases shouldn't lead to abnormal program termination
> with coredumps.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d 
> 
> 
> Diff: https://reviews.apache.org/r/60598/diff/2/
> 
> 
> Testing
> -------
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message