mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 59131: Added an IPv6 address storage to UPID.
Date Wed, 05 Jul 2017 23:16:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59131/#review179727
-----------------------------------------------------------




3rdparty/libprocess/include/process/pid.hpp
Lines 97 (patched)
<https://reviews.apache.org/r/59131/#comment254564>

    ```
    struct
    {
    #ifdef __WINDOWS__
      Option<network::unix::Address> unix;
    #endif // __WINDOWS__
      Option<network::inet4::Address> v4;
      Option<network::inet6::Address> v6;
    } address;
    ```
    
    ?


- Benjamin Hindman


On June 29, 2017, 11:23 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59131/
> -----------------------------------------------------------
> 
> (Updated June 29, 2017, 11:23 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7488
>     https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an IPv6 address storage to UPID.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/pid.hpp c634916a37f570194945b9c7d7b786ffeae0408a

>   3rdparty/libprocess/src/pid.cpp 023f881841f466d91243d2773961b67f82da4e91 
> 
> 
> Diff: https://reviews.apache.org/r/59131/diff/5/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message