-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59762/#review179719
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/mesos.proto
Lines 869 (patched)
<https://reviews.apache.org/r/59762/#comment254554>
Can you also add text here saying all masters should belong to the same region?
include/mesos/v1/mesos.proto
Lines 868 (patched)
<https://reviews.apache.org/r/59762/#comment254555>
ditto.
src/tests/slave_tests.cpp
Line 7478 (original), 7478 (patched)
<https://reviews.apache.org/r/59762/#comment254561>
2 new lines.
src/tests/slave_tests.cpp
Lines 7480 (patched)
<https://reviews.apache.org/r/59762/#comment254559>
s/changed/configured/ ?
src/tests/slave_tests.cpp
Lines 7506 (patched)
<https://reviews.apache.org/r/59762/#comment254560>
s/slave/agent/ ?
- Vinod Kone
On July 5, 2017, 10:32 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59762/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 10:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7610
> https://issues.apache.org/jira/browse/MESOS-7610
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This means that each master's domain is stored in ZooKeeper, along with
> the rest of the MasterInfo protobuf message.
>
> Each agent's domain is stored as part of its checkpointed resources.
> Changing the agent's domain requires a full drain of the agent; this
> behavior might be relaxed in the future.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 4e4b2790615e8bbbf262ba809cbfd67e24368952
> include/mesos/v1/mesos.proto b8625d363388bc707bc2458abd47a218cc7b7888
> src/common/http.hpp b7e4a8adcbcaa3a962af795c67694a35161b6c1a
> src/common/http.cpp fdb591eccf273260902f3f695cf431f72ee3d817
> src/common/type_utils.cpp aeb16238e9c3fd71a8e9e57dbb8098ddc004e1f2
> src/internal/evolve.hpp 9db5fe6155243576f186a8b974e81068505b9fcb
> src/internal/evolve.cpp 93196f301e820b99572ee008b98a124ddafe9697
> src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a
> src/master/master.cpp 56b170ed70722eba30d98f6e648b6a31580d6b56
> src/slave/http.cpp 700871e1502a65b0bb1fc31219e09219dbdb5340
> src/slave/slave.cpp 0e24b8cb8d1020af515e3d1862e121e1daf82ce9
> src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9
> src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f
> src/tests/mesos.hpp eac2c96985cdbbf1a50cfc054862eae2d44fbfcd
> src/tests/slave_tests.cpp 8a69cc2ede0b2f17a31986e9142aa2081691eb5e
> src/v1/mesos.cpp 423510ef14025dba208ef85edf5305c2ce58f01d
>
>
> Diff: https://reviews.apache.org/r/59762/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
|