mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 60652: Bundled rake as part of managed ruby dependencies of website.
Date Wed, 05 Jul 2017 22:03:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60652/#review179711
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On July 5, 2017, 11:08 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60652/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 11:08 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While rake is available from the package manager on some flavors of
> Linux, on e.g., macOS seems to currently only be available as a gem.
> In order to provide a working website environment with minimal extra
> configuration, bundle rake with bundler as well.
> 
> We also update the existing website tooling to use the now bundled
> version of rake.
> 
> 
> Diffs
> -----
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
> 
> 
> Diff: https://reviews.apache.org/r/60652/diff/1/
> 
> 
> Testing
> -------
> 
> `bundle install && bundle exec rake && bundle exec rake dev` on macOS.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message