-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/#review179691
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.cpp
Lines 4543 (patched)
<https://reviews.apache.org/r/59233/#comment254506>
s/Setup/Set up/
src/slave/slave.cpp
Lines 4545 (patched)
<https://reviews.apache.org/r/59233/#comment254507>
... the protocol is set to `IPv4` and therefore we don't explicitly set the protocol here.
- Benjamin Hindman
On June 29, 2017, 11:22 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59233/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 11:22 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently the agent is populating only the v4 address for containers
> running on the host network. However, clusters running on a dual stack
> network need to report v4 and v6 address for containers running on the
> host network. This change allows v6 address specified by operators to be
> advertised for containers running on the host network.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3338349c399c9fb5b7fb2fc5886fb492ffb944c4
> include/mesos/v1/mesos.proto 6f0ad71260c36a9cb401c716e02c561580fb433b
> src/slave/slave.cpp 1f7aed48eb3ab3ee2a797d4061a6e289852b8199
>
>
> Diff: https://reviews.apache.org/r/59233/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
|