mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Re: Review Request 60620: Modify os::write to write binary files on Windows.
Date Wed, 05 Jul 2017 17:43:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/
-----------------------------------------------------------

(Updated July 5, 2017, 5:43 p.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
-------

Modify os::write to write binary files on Windows.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/write.hpp beb5bd83b52565a75e34d32b5bb17951bc799578 


Diff: https://reviews.apache.org/r/60620/diff/2/

Changes: https://reviews.apache.org/r/60620/diff/1-2/


Testing
-------

Built successfully on both Linux (with autotools and cmake) and Windows (with cmake).

Ran stout-tests and mesos-tests successfully on both Windows and Linux.


Thanks,

Jeff Coffler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message