mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 60280: Provide full path to the custom executor.
Date Wed, 05 Jul 2017 16:48:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60280/#review179650
-----------------------------------------------------------




src/slave/containerizer/mesos/launch.cpp
Lines 799 (patched)
<https://reviews.apache.org/r/60280/#comment254459>

    This is still based on the assumption that `launchInfo` has `working_directory()` set.
Can you do the following instead:
    ```
    Result<string> realpath = os::realpath(executable);
    if (!realpath.isSome()) {
      ...
    }
    ```


- Jie Yu


On July 3, 2017, 6:35 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60280/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 6:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu, James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-7703
>     https://issues.apache.org/jira/browse/MESOS-7703
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a framework specifies use of its own executor and sets shell to false the executor
is never found. This provides the full path to the executor so that the `execvp` or `execvpe`
is successful.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp 162ca1c2e 
> 
> 
> Diff: https://reviews.apache.org/r/60280/diff/6/
> 
> 
> Testing
> -------
> 
> `cd build && cmake .. -DCMAKE_BUILD_TYPE=Release && make -j4`
> Also spun up a master and agent, connected and sent a task using the UCR (both with and
without the use of an OCI image) via our own framework, and checked the sandbox to verify
that things went accordingly.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message