mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.
Date Wed, 05 Jul 2017 16:29:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60598/#review179643
-----------------------------------------------------------




3rdparty/libprocess/src/subprocess.cpp
Lines 172-173 (original), 172-177 (patched)
<https://reviews.apache.org/r/60598/#comment254455>

    This does two things, remove `abort()` and fix this code to gracefully handle `EINTR`.
We usually try to do one thing at a time, so it might make sense to pull the `EINTR` fix into
a separate RR.



3rdparty/libprocess/src/subprocess.cpp
Lines 176 (patched)
<https://reviews.apache.org/r/60598/#comment254458>

    Any reason we cannot do a proper `exit` here?
    
    Here and below.


- Benjamin Bannier


On July 3, 2017, 4:58 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60598/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 4:58 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and
James Peach.
> 
> 
> Bugs: MESOS-7160
>     https://issues.apache.org/jira/browse/MESOS-7160
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, abort() was called in SUPERVISOR hook when child process
> exited with an error code, or waitpid() failed, or parent process
> exited. All these cases shouldn't lead to abnormal program termination
> with coredumps.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d 
> 
> 
> Diff: https://reviews.apache.org/r/60598/diff/2/
> 
> 
> Testing
> -------
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message