mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 60653: Tightened namespace to fix a lookup error on Windows.
Date Wed, 05 Jul 2017 13:58:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60653/
-----------------------------------------------------------

(Updated July 5, 2017, 3:58 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Bannier.


Repository: mesos


Description
-------

The Visual C++ compiler tried to lookup 'protobuf::parse' in the
'mesos::internal::protobuf' namespace. This is fixed by explicitly
setting the namespace.


Diffs (updated)
-----

  src/resource_provider/daemon.cpp 243396dfe735c0ee421071dfc5df3c9d1c103e45 


Diff: https://reviews.apache.org/r/60653/diff/3/

Changes: https://reviews.apache.org/r/60653/diff/2-3/


Testing
-------

make check and made sure it compiles with Windows.


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message