mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60653: Tightened namespace to fix a lookup error on Windows.
Date Wed, 05 Jul 2017 11:28:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60653/#review179622
-----------------------------------------------------------


Ship it!




Could you update the commit message to maybe include there error we were seeing? Might also
be worth calling at that we use this pattern elsewhere already when calling `protobuf::parse`.

- Benjamin Bannier


On July 5, 2017, 1:26 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60653/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 1:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tightened namespace to fix a lookup error on Windows.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/daemon.cpp 243396dfe735c0ee421071dfc5df3c9d1c103e45 
> 
> 
> Diff: https://reviews.apache.org/r/60653/diff/1/
> 
> 
> Testing
> -------
> 
> make check and made sure it compiles with Windows.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message