mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Review Request 60628: Enable fetcher_tests.cpp unit test module on Windows platform.
Date Mon, 03 Jul 2017 19:35:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60628/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
-------

Document that some FetcherTest tests won't work on Windows platform.
  Tests for tar, gzip, and such won't be working on Windows for
  the time being. Thoughts are to provide this capability to the
  Fetcher in a cross-platform manner via a programmatic code library
  rather than Linux-specific command line tools (tar, gzip, etc).

  In the short term, zip and unzip will work since PowerShell can
  support that natively.

Fix FetcherTest.AbsoluteCustomSubdirectoryFails on Windows platform.
Test FetcherTest.InvalidUser can't work on Windows for now.
Fix test FetcherTest.NonExistingFile on Windows platform.
Fix test FetcherTest.AbsolutePath on Windows platform.
Fix test FetcherTest.RelativeFilePath on Windows platform.
Fix test FetcherTest.OSNetUriTest on Windows platform.
Fix test FetcherTest.OSNetUriSpaceTest on Windows platform.
Fix test FetcherTest.FileLocalhostURI on Windows platform.
Fix test FetcherTest.Unzip_ExtractFile on Windows platform.
Fix test FetcherTest.Unzip_ExtractInvalidFile on Windows platform.
Fix test Unzip_ExtractFileWithDuplicatedEntries on Windows platform.
Fix test FetcherTest.UseCustomOutputFile on Windows platform.


Diffs
-----

  src/launcher/CMakeLists.txt 97edc4a28a995da8a5e963aaa62c4c955cc59719 
  src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87 
  src/slave/containerizer/fetcher.cpp e3c786b36ad16b33ef9d3eed15f722890e80f0bb 
  src/tests/fetcher_tests.cpp 99149baa1c7abfabf572a0d0f4512a8e84d1e5be 


Diff: https://reviews.apache.org/r/60628/diff/1/


Testing
-------

See upstream.


Thanks,

Jeff Coffler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message