mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.
Date Mon, 03 Jul 2017 14:58:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60598/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Benjamin Mahler, and James Peach.


Bugs: MESOS-7160
    https://issues.apache.org/jira/browse/MESOS-7160


Repository: mesos


Description
-------

Previously, abort() was called in SUPERVISOR hook when child process
exited with an error code, or waitpid() failed, or parent process
exited. All these cases shouldn't lead to abnormal program termination
with coredumps.


Diffs
-----

  3rdparty/libprocess/include/process/posix/subprocess.hpp a5d10ce49d348b4fe7b2c27c48e624b0a1c31e77

  3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d 


Diff: https://reviews.apache.org/r/60598/diff/1/


Testing
-------

make check (mac os x, fedora 25)


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message