mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 60280: Provide full path to the custom executor.
Date Mon, 03 Jul 2017 14:51:26 GMT


> On June 30, 2017, 11:48 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Lines 799 (patched)
> > <https://reviews.apache.org/r/60280/diff/3/?file=1758435#file1758435line799>
> >
> >     What if `launchInfo.working_directory()` is not set? Maybe use os::realpath
here to get the absolute path?

Sure, I'll alter that. Is it wrong to assume that the working directory will always be set
at this point? I thought that without the sandbox work dir no container would be able to move
forward.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60280/#review179433
-----------------------------------------------------------


On June 22, 2017, 3:20 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60280/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 3:20 p.m.)
> 
> 
> Review request for mesos, Jie Yu, James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-7703
>     https://issues.apache.org/jira/browse/MESOS-7703
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a framework specifies use of its own executor and sets shell to false the executor
is never found. This provides the full path to the executor so that the `execvp` or `execvpe`
is successful.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp 162ca1c2e 
> 
> 
> Diff: https://reviews.apache.org/r/60280/diff/3/
> 
> 
> Testing
> -------
> 
> `cd build && cmake .. -DCMAKE_BUILD_TYPE=Release && make -j4`
> Also spun up a master and agent, connected and sent a task using the UCR (both with and
without the use of an OCI image) via our own framework, and checked the sandbox to verify
that things went accordingly.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message