mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 60397: Check perf version compatibility in tests with disabled coredumps.
Date Mon, 03 Jul 2017 10:57:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/
-----------------------------------------------------------

(Updated July 3, 2017, 10:57 a.m.)


Review request for mesos, Benjamin Bannier, James Peach, and Neil Conway.


Bugs: MESOS-7160
    https://issues.apache.org/jira/browse/MESOS-7160


Repository: mesos


Description
-------

For autotools build, the docker-build script performs a 'distcheck'
build. This type of build warns if any unexpected files are left in
the build directory after an uninstall, mainly to detect broken
uninstall Makefile rules. The return status of the build container is
the result of the distcheck.
This fixes an issue where in some dockerized configurations
invocations of 'perf' segfaulted (producing a core file as a
side-effect), where the failure case was already anticipated and
handled by the caller.


Diffs (updated)
-----

  src/linux/perf.cpp b301e25d5cac6488c57e4f983e4867c72368a040 
  src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e 


Diff: https://reviews.apache.org/r/60397/diff/3/

Changes: https://reviews.apache.org/r/60397/diff/2-3/


Testing
-------

1. make check (mac os x 10.12, fedora 25)
2. internal CI

Needs to be confirmed by Apache CI, e.g., reviewbot.


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message