mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 60107: Added filtering to the '/tasks' endpoint.
Date Mon, 03 Jul 2017 09:51:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179488
-----------------------------------------------------------



I think the acceptor files do not belong in the `common/http.?pp` files. Perhaps create a
new header called acceptors?


src/common/http.hpp
Lines 163-171 (patched)
<https://reviews.apache.org/r/60107/#comment254231>

    This class is not necessary. The acceptor as a concept exist, but we don't use any of
the advantages of inheritance, I think this would be served better in a namespace.



src/common/http.hpp
Lines 175-229 (patched)
<https://reviews.apache.org/r/60107/#comment254235>

    What is the point of having multiple different `AuthorizationAcceptors`? Each have a method
with a different signature, so I can see them merge into one common acceptor.



src/common/http.hpp
Lines 181 (patched)
<https://reviews.apache.org/r/60107/#comment254232>

    This should be a const reference, we don't want to copy `Owned` pointers.


- Alexander Rojas


On July 1, 2017, 1:57 a.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> -----------------------------------------------------------
> 
> (Updated July 1, 2017, 1:57 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/15/
> 
> 
> Testing
> -------
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000
--gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message