mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60566: Validated and upgraded resources on the V1 operator API path.
Date Sat, 01 Jul 2017 08:29:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60566/#review179468
-----------------------------------------------------------


Fix it, then Ship it!




Tests look good.


src/tests/master_tests.cpp
Lines 7691-7692 (patched)
<https://reviews.apache.org/r/60566/#comment254179>

    make a non-refined reservation?
    
    using pre and post formats?
    
    Ditto on the other test descriptions as applicable.



src/tests/master_tests.cpp
Lines 7699-7701 (patched)
<https://reviews.apache.org/r/60566/#comment254177>

    Yikes, this is generally something we try to forbid as 50 milliseconds across thousands
of tests adds up. Can you pause instead? Ditto elsewhere.



src/tests/master_tests.cpp
Lines 7718-7720 (patched)
<https://reviews.apache.org/r/60566/#comment254180>

    Is that something we're going to do? Looking at where the default framework info is coming
from, I don't see any comment there.
    
    Ditto elsewhere on the other TODOs.



src/tests/master_tests.cpp
Lines 7919 (patched)
<https://reviews.apache.org/r/60566/#comment254178>

    Any reason the above tests say V1 and this one doesn't?



src/tests/master_tests.cpp
Lines 7997-8000 (patched)
<https://reviews.apache.org/r/60566/#comment254181>

    Why did you need the launch task part of this test? Seems a bit simpler if we can take
it out and just have create / destroy tested.


- Benjamin Mahler


On June 30, 2017, 12:56 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60566/
> -----------------------------------------------------------
> 
> (Updated June 30, 2017, 12:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/master/master.hpp 9dd6a530c373516dc81bfd51ee6e95f25588148f 
>   src/tests/master_tests.cpp cfb799fd105e9880cd56415b2a84e604c8f62703 
>   src/tests/persistent_volume_endpoints_tests.cpp 518bdf858096ec9bcfa4f899ead5a6c3d103c521

>   src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5

> 
> 
> Diff: https://reviews.apache.org/r/60566/diff/1/
> 
> 
> Testing
> -------
> 
> Added new tests + `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message