mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 60564: Performed validation/upgrade of `Resource` objects before authorization.
Date Sat, 01 Jul 2017 02:49:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60564/#review179452
-----------------------------------------------------------




src/master/master.cpp
Lines 3845-3856 (original), 3845-3856 (patched)
<https://reviews.apache.org/r/60564/#comment254148>

    don't we need to do this (recovering of resources when offer is in error) in your below
block as well?



src/master/master.cpp
Lines 3999 (patched)
<https://reviews.apache.org/r/60564/#comment254149>

    see my comment above.  you need to recover resources for dropped operations. can you add
a test?


- Vinod Kone


On June 30, 2017, 9:02 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60564/
> -----------------------------------------------------------
> 
> (Updated June 30, 2017, 9:02 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7735
>     https://issues.apache.org/jira/browse/MESOS-7735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Performed validation/upgrade of `Resource` objects before authorization.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 95e9691b3e3ef101e3e7ddc7a498d5c5bf2276e3 
>   src/tests/master_tests.cpp cfb799fd105e9880cd56415b2a84e604c8f62703 
> 
> 
> Diff: https://reviews.apache.org/r/60564/diff/2/
> 
> 
> Testing
> -------
> 
> Added a new test + `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message