mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.
Date Sat, 01 Jul 2017 02:13:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60562/#review179450
-----------------------------------------------------------


Fix it, then Ship it!




This is great. Thanks for the cleanup.


src/master/master.cpp
Line 3819 (original)
<https://reviews.apache.org/r/60562/#comment254144>

    Can you add a TODO to add metrics for LAUNCH_GROUP launch and decline as well?



src/master/master.cpp
Line 3940 (original), 3927 (patched)
<https://reviews.apache.org/r/60562/#comment254146>

    move this to #4005?



src/master/master.cpp
Lines 3997 (patched)
<https://reviews.apache.org/r/60562/#comment254145>

    Can you log a warning here?


- Vinod Kone


On June 30, 2017, 9:01 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60562/
> -----------------------------------------------------------
> 
> (Updated June 30, 2017, 9:01 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7735
>     https://issues.apache.org/jira/browse/MESOS-7735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It used to be that the minor adjustments that were made to operations
> were done in various places across `accept` and `_accept`.
> 
> The "executor-injection" for LAUNCH_GROUP was at the beginning of
> `accept`, "allocation-info-injection" for MULTI_ROLE was after offer
> validation, and "health-check-injection" for LAUNCH was in `_accept`.
> 
> The `Master::accept` function is now broken down into distinct
> "metrics accounting", "offer validation", "operation-adjustments", and
> "authorization" stages.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 276b18e4d1bab7e9b28c1c93fe13c93a38abc5cd 
> 
> 
> Diff: https://reviews.apache.org/r/60562/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message