From reviews-return-62758-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jun 28 21:51:35 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C748219B42 for ; Wed, 28 Jun 2017 21:51:35 +0000 (UTC) Received: (qmail 48047 invoked by uid 500); 28 Jun 2017 21:51:35 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 48015 invoked by uid 500); 28 Jun 2017 21:51:35 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 48001 invoked by uid 99); 28 Jun 2017 21:51:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jun 2017 21:51:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 09A58CCF86; Wed, 28 Jun 2017 21:51:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.24 X-Spam-Level: *** X-Spam-Status: No, score=3.24 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tSMGBxj-e55n; Wed, 28 Jun 2017 21:51:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8E51F5F6D3; Wed, 28 Jun 2017 21:51:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 33CC9E0026; Wed, 28 Jun 2017 21:51:33 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 24883C40019; Wed, 28 Jun 2017 21:51:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2720419685551250470==" MIME-Version: 1.0 Subject: Re: Review Request 60107: Added filtering to the '/tasks' endpoint. From: Greg Mann To: Anand Mazumdar , Greg Mann , Vinod Kone , Alexander Rojas Cc: Quinn Leng , mesos Date: Wed, 28 Jun 2017 21:51:33 -0000 Message-ID: <20170628215133.27544.71766@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60107/ X-Sender: Greg Mann References: <20170628213858.22176.30441@reviews-vm2.apache.org> In-Reply-To: <20170628213858.22176.30441@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============2720419685551250470== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179184 ----------------------------------------------------------- src/common/http.hpp Lines 40-42 (patched) We always fully qualify all namespaces in headers (i.e., no `using` statements). It will make some of the lines really long, but that's OK. - Greg Mann On June 28, 2017, 9:38 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60107/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 9:38 p.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7630 > https://issues.apache.org/jira/browse/MESOS-7630 > > > Repository: mesos > > > Description > ------- > > Added filtering to the '/tasks' endpoint. > > > Diffs > ----- > > src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e > src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 > src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 > src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea > > > Diff: https://reviews.apache.org/r/60107/diff/6/ > > > Testing > ------- > > Passed "make check" > Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" > Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" > > > Thanks, > > Quinn Leng > > --===============2720419685551250470==--