From reviews-return-62734-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jun 28 14:08:09 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EF81C1A57C for ; Wed, 28 Jun 2017 14:08:09 +0000 (UTC) Received: (qmail 24071 invoked by uid 500); 28 Jun 2017 14:08:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 24038 invoked by uid 500); 28 Jun 2017 14:08:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 24026 invoked by uid 99); 28 Jun 2017 14:08:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jun 2017 14:08:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DF3EFCCE31; Wed, 28 Jun 2017 14:08:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.24 X-Spam-Level: *** X-Spam-Status: No, score=3.24 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9dfG5JTWQy48; Wed, 28 Jun 2017 14:08:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BACEB60D33; Wed, 28 Jun 2017 14:08:06 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1F15DE059C; Wed, 28 Jun 2017 14:08:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 10C7BC40019; Wed, 28 Jun 2017 14:08:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3868889412829578022==" MIME-Version: 1.0 Subject: Re: Review Request 59937: Added agent `--resource_provider_config_dir` flag. From: Benjamin Bannier To: Benjamin Bannier , Benjamin Mahler , Jan Schlicht Cc: Jie Yu , mesos Date: Wed, 28 Jun 2017 14:08:06 -0000 Message-ID: <20170628140806.20029.47488@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59937/ X-Sender: Benjamin Bannier References: <20170626043152.43242.48379@reviews-vm2.apache.org> In-Reply-To: <20170626043152.43242.48379@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============3868889412829578022== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59937/#review179100 ----------------------------------------------------------- docs/configuration.md Lines 1900 (patched) ... representing _a_ ... docs/configuration.md Lines 1903 (patched) ... handling operations _on_ the resources ... docs/configuration.md Lines 1907-1908 (patched) Could we call out why we do not expose `resources` here? I imagine this is due to us wanted to determine them automatically on RP startup? To call it out here instead of e.g., the proto definition probably does make sense, since the proto definition could be used differently in different contexts. src/slave/flags.cpp Lines 98-109 (patched) See comments in `configuration.md`. - Benjamin Bannier On June 26, 2017, 6:31 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59937/ > ----------------------------------------------------------- > > (Updated June 26, 2017, 6:31 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht. > > > Bugs: MESOS-7571 > https://issues.apache.org/jira/browse/MESOS-7571 > > > Repository: mesos > > > Description > ------- > > Added agent `--resource_provider_config_dir` flag. > > > Diffs > ----- > > docs/configuration.md 0eb696a949003ff11831aed5e4f4ab384cf9992e > src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c > src/slave/flags.cpp c84aa6724170bba46b4444be8410b71d42a1626e > > > Diff: https://reviews.apache.org/r/59937/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============3868889412829578022==--