From reviews-return-62712-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 27 20:07:49 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A28119C11 for ; Tue, 27 Jun 2017 20:07:49 +0000 (UTC) Received: (qmail 15371 invoked by uid 500); 27 Jun 2017 20:07:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 15331 invoked by uid 500); 27 Jun 2017 20:07:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 15320 invoked by uid 99); 27 Jun 2017 20:07:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 20:07:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7807AC0311; Tue, 27 Jun 2017 20:07:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6TWleXvU9ReM; Tue, 27 Jun 2017 20:07:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B1A6F5F60D; Tue, 27 Jun 2017 20:07:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0F0FCE00A0; Tue, 27 Jun 2017 20:07:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id F3886C403E9; Tue, 27 Jun 2017 20:07:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4618454872197935650==" MIME-Version: 1.0 Subject: Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits. From: Andrew Schwartzmeyer To: Benjamin Bannier , Joseph Wu , Michael Park Cc: mesos Date: Tue, 27 Jun 2017 20:07:45 -0000 Message-ID: <20170627200745.20029.88162@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60216/ X-Sender: Andrew Schwartzmeyer References: <20170627194134.20028.75020@reviews-vm2.apache.org> In-Reply-To: <20170627194134.20028.75020@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============4618454872197935650== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60216/ ----------------------------------------------------------- (Updated June 27, 2017, 8:07 p.m.) Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park. Bugs: MESOS-4331 https://issues.apache.org/jira/browse/MESOS-4331 Repository: mesos Description ------- The capitalization check caused rebases to fail for commits made with `--fixup` and `--squash`. This change ignores the check for these cases. Diffs (updated) ----- support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca Diff: https://reviews.apache.org/r/60216/diff/3/ Changes: https://reviews.apache.org/r/60216/diff/2-3/ Testing ------- Thanks, Andrew Schwartzmeyer --===============4618454872197935650==--