From reviews-return-62690-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 27 10:33:49 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29D171A3DB for ; Tue, 27 Jun 2017 10:33:49 +0000 (UTC) Received: (qmail 28370 invoked by uid 500); 27 Jun 2017 10:33:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 28331 invoked by uid 500); 27 Jun 2017 10:33:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 28320 invoked by uid 99); 27 Jun 2017 10:33:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 10:33:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5A5EE1A039F; Tue, 27 Jun 2017 10:33:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id n9v1fIvkCP4k; Tue, 27 Jun 2017 10:33:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1BC705FB5C; Tue, 27 Jun 2017 10:33:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AB8A4E00A0; Tue, 27 Jun 2017 10:33:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 23B48C400BC; Tue, 27 Jun 2017 10:33:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7770831136494829644==" MIME-Version: 1.0 Subject: Re: Review Request 60438: Updated endpoint help generator script to work inside Docker. From: Benjamin Mahler To: haosdent huang , Benjamin Mahler Cc: Vinod Kone , mesos Date: Tue, 27 Jun 2017 10:33:44 -0000 Message-ID: <20170627103344.25950.90577@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60438/ X-Sender: Benjamin Mahler References: <20170627102919.25950.82253@reviews-vm2.apache.org> In-Reply-To: <20170627102919.25950.82253@reviews-vm2.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============7770831136494829644== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 27, 2017, 10:29 a.m., Benjamin Mahler wrote: > > It's ok for now, but our current approach means that only the help endpoints for those components that are run as part of this script will show up. So for example, if the cgroups isolator exposes some endpoints these will not be published to the website. I think longer term if we have the help stored in markdown we can avoid this issue. Can you add a comment about it needing to work within docker hence the flags? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60438/#review178969 ----------------------------------------------------------- On June 26, 2017, 5:54 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60438/ > ----------------------------------------------------------- > > (Updated June 26, 2017, 5:54 p.m.) > > > Review request for mesos, Benjamin Mahler and haosdent huang. > > > Bugs: MESOS-7625 > https://issues.apache.org/jira/browse/MESOS-7625 > > > Repository: mesos > > > Description > ------- > > Changed agent flags to make this script work inside Docker container. > This is needed because this script will be run as part of website > publishing process which runs on ASF CI inside Docker. > > > Diffs > ----- > > support/generate-endpoint-help.py 6eb2d41b35c5f064839c29a0ba8326c590a33213 > > > Diff: https://reviews.apache.org/r/60438/diff/1/ > > > Testing > ------- > > Tested by running a CI job pointing to a branch containing this patch. > > > Thanks, > > Vinod Kone > > --===============7770831136494829644==--