From reviews-return-62582-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jun 22 22:31:48 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D6DA1AA61 for ; Thu, 22 Jun 2017 22:31:48 +0000 (UTC) Received: (qmail 36102 invoked by uid 500); 22 Jun 2017 22:31:48 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36068 invoked by uid 500); 22 Jun 2017 22:31:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36056 invoked by uid 99); 22 Jun 2017 22:31:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jun 2017 22:31:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 31677C059A; Thu, 22 Jun 2017 22:31:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id StQAAChrNiFU; Thu, 22 Jun 2017 22:31:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 036B35F5B3; Thu, 22 Jun 2017 22:31:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A468CE00A3; Thu, 22 Jun 2017 22:31:45 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 92848C40055; Thu, 22 Jun 2017 22:31:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1086633024911164898==" MIME-Version: 1.0 Subject: Re: Review Request 60352: Relaxed the resource format restriction for frameworks. From: Neil Conway To: Neil Conway Cc: Michael Park , mesos Date: Thu, 22 Jun 2017 22:31:45 -0000 Message-ID: <20170622223145.61729.3934@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60352/ X-Sender: Neil Conway X-ReviewBoard-ShipIt: 1 References: <20170622003256.39410.8552@reviews-vm2.apache.org> In-Reply-To: <20170622003256.39410.8552@reviews-vm2.apache.org> Reply-To: Neil Conway X-ReviewRequest-Repository: mesos --===============1086633024911164898== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60352/#review178757 ----------------------------------------------------------- Ship it! Per offline discussion, add more on rationale to commit message. - Neil Conway On June 22, 2017, 12:32 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60352/ > ----------------------------------------------------------- > > (Updated June 22, 2017, 12:32 a.m.) > > > Review request for mesos and Neil Conway. > > > Repository: mesos > > > Description > ------- > > This patch relaxes the validation such that a framework with > RESERVATION_REFINEMENT capability can send the old resources format as > well. This is more of a temporary solution due to the complexity of > the validation code, and we will revisit whether we want to restrict > RESERVATION_REFINEMENT-capable frameworks to the new format. MESOS-7705. > > > Diffs > ----- > > src/master/validation.hpp 129505948c0fad28743e290f24df55918c8d601c > src/master/validation.cpp 4d0af26fedb6ef3039536cb42d2ac9112c9f4bdd > > > Diff: https://reviews.apache.org/r/60352/diff/4/ > > > Testing > ------- > > > Thanks, > > Michael Park > > --===============1086633024911164898==--