From reviews-return-62551-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jun 22 15:28:22 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1BCB19677 for ; Thu, 22 Jun 2017 15:28:22 +0000 (UTC) Received: (qmail 31103 invoked by uid 500); 22 Jun 2017 15:28:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31073 invoked by uid 500); 22 Jun 2017 15:28:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31058 invoked by uid 99); 22 Jun 2017 15:28:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jun 2017 15:28:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D4827C061E; Thu, 22 Jun 2017 15:28:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xjbxBbHrH-Rx; Thu, 22 Jun 2017 15:28:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5107760CD9; Thu, 22 Jun 2017 15:28:20 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AC66AE00A3; Thu, 22 Jun 2017 15:28:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 994AEC40055; Thu, 22 Jun 2017 15:28:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1528118034261790584==" MIME-Version: 1.0 Subject: Re: Review Request 60346: Improved the documentation of 'TASK_LOST'. From: Mesos Reviewbot To: Neil Conway Cc: Mesos Reviewbot , =?utf-8?q?Gast=C3=B3n_Kleiman?= , mesos Date: Thu, 22 Jun 2017 15:28:19 -0000 Message-ID: <20170622152819.61729.28505@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60346/ X-Sender: Mesos Reviewbot References: <20170621221752.12058.33155@reviews-vm2.apache.org> In-Reply-To: <20170621221752.12058.33155@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============1528118034261790584== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60346/#review178689 ----------------------------------------------------------- Patch looks great! Reviews applied: [60346] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 21, 2017, 10:17 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60346/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 10:17 p.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-7662 > https://issues.apache.org/jira/browse/MESOS-7662 > > > Repository: mesos > > > Description > ------- > > Updated the protobuf comments to clarify that 'TASK_LOST' is not > always a terminal state. > > > Diffs > ----- > > include/mesos/mesos.proto 38449da44a5288afc7e2ef17ef5e1380ecabd5d2 > include/mesos/v1/mesos.proto 81eca47ce1074f5e522a0410f01ab2b2cfc76aa2 > > > Diff: https://reviews.apache.org/r/60346/diff/1/ > > > Testing > ------- > > None, this is not functional change. > > > Thanks, > > Gastón Kleiman > > --===============1528118034261790584==--