From reviews-return-62387-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 20 17:29:26 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E9A518227 for ; Tue, 20 Jun 2017 17:29:26 +0000 (UTC) Received: (qmail 84006 invoked by uid 500); 20 Jun 2017 17:29:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 83974 invoked by uid 500); 20 Jun 2017 17:29:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83951 invoked by uid 99); 20 Jun 2017 17:29:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jun 2017 17:29:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D52891B0F27; Tue, 20 Jun 2017 17:29:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MV_EPJE-tlyB; Tue, 20 Jun 2017 17:29:23 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0D2C55F283; Tue, 20 Jun 2017 17:29:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A80DBE0026; Tue, 20 Jun 2017 17:29:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id CA02DC4021B; Tue, 20 Jun 2017 17:29:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5924455881507458507==" MIME-Version: 1.0 Subject: Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits. From: Andrew Schwartzmeyer To: Benjamin Bannier , Joseph Wu , Michael Park Cc: mesos Date: Tue, 20 Jun 2017 17:29:20 -0000 Message-ID: <20170620172920.1926.99915@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60216/ X-Sender: Andrew Schwartzmeyer References: <20170620083519.24477.65069@reviews-vm2.apache.org> In-Reply-To: <20170620083519.24477.65069@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============5924455881507458507== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 20, 2017, 8:35 a.m., Benjamin Bannier wrote: > > I think this does not work as is since we would e.g., still reject commits where the commit summary is longer than 72 chars, e.g., the following commit summary should be considered formally okay, > > > > fixup fixup squash AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA. > > > > One way to achieve that would be to e.g., treat the length check of the summary line separately from the description, but maybe you have a better idea. Oh, good catch. I'll ponder it. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60216/#review178357 ----------------------------------------------------------- On June 19, 2017, 11:18 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60216/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 11:18 p.m.) > > > Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park. > > > Bugs: MESOS-4331 > https://issues.apache.org/jira/browse/MESOS-4331 > > > Repository: mesos > > > Description > ------- > > The capitalization check caused rebases to fail for commits made with > `--fixup` and `--squash`. This change ignores the check for these cases. > > > Diffs > ----- > > support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca > > > Diff: https://reviews.apache.org/r/60216/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============5924455881507458507==--