From reviews-return-62319-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 20 05:32:50 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26F041A2B9 for ; Tue, 20 Jun 2017 05:32:50 +0000 (UTC) Received: (qmail 18294 invoked by uid 500); 20 Jun 2017 05:32:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 18261 invoked by uid 500); 20 Jun 2017 05:32:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 18250 invoked by uid 99); 20 Jun 2017 05:32:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jun 2017 05:32:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 153C3C0118; Tue, 20 Jun 2017 05:32:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jNpHAalw2DFH; Tue, 20 Jun 2017 05:32:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E3AA35F2F1; Tue, 20 Jun 2017 05:32:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7CC6DE0051; Tue, 20 Jun 2017 05:32:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B62E0C402CE; Tue, 20 Jun 2017 05:32:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1970235113286815419==" MIME-Version: 1.0 Subject: Re: Review Request 60181: Resources: Updated the comment to mention the resource format [1/N]. From: Michael Park To: Neil Conway Cc: Michael Park , Alexander Rukletsov , mesos Date: Tue, 20 Jun 2017 05:32:45 -0000 Message-ID: <20170620053245.24478.58986@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Michael Park X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60181/ X-Sender: Michael Park References: <20170619051709.15892.89746@reviews-vm2.apache.org> In-Reply-To: <20170619051709.15892.89746@reviews-vm2.apache.org> Reply-To: Michael Park X-ReviewRequest-Repository: mesos --===============1970235113286815419== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60181/ ----------------------------------------------------------- (Updated June 19, 2017, 10:32 p.m.) Review request for mesos and Neil Conway. Bugs: MESOS-7655 https://issues.apache.org/jira/browse/MESOS-7655 Repository: mesos Description (updated) ------- With reservation refinement, `Resources` always stores `Resource` objects that are validated, and in the "post-reservation-refinement" format. Diffs (updated) ----- include/mesos/resources.hpp be2e377ab9a7332adf373c585e5fafd47ce79f7e include/mesos/v1/resources.hpp fe62166f20088504bdf90a178d3e3b0a94cdc1ac Diff: https://reviews.apache.org/r/60181/diff/3/ Changes: https://reviews.apache.org/r/60181/diff/2-3/ Testing ------- Thanks, Michael Park --===============1970235113286815419==--