From reviews-return-61827-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jun 9 19:21:28 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AD25192F4 for ; Fri, 9 Jun 2017 19:21:28 +0000 (UTC) Received: (qmail 55191 invoked by uid 500); 9 Jun 2017 19:21:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 55158 invoked by uid 500); 9 Jun 2017 19:21:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 55147 invoked by uid 99); 9 Jun 2017 19:21:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jun 2017 19:21:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 582931A0743; Fri, 9 Jun 2017 19:21:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id rkPp6nqamFZs; Fri, 9 Jun 2017 19:21:25 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 90FFE5F5B7; Fri, 9 Jun 2017 19:21:24 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 43CDFE01D8; Fri, 9 Jun 2017 19:21:23 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C7620C40040; Fri, 9 Jun 2017 19:21:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0999759703590995039==" MIME-Version: 1.0 Subject: Re: Review Request 59950: Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`. From: Mesos Reviewbot Windows To: Anand Mazumdar , Jie Yu Cc: Mesos Reviewbot Windows , Avinash sridharan , mesos Date: Fri, 09 Jun 2017 19:21:22 -0000 Message-ID: <20170609192122.7067.46927@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59950/ X-Sender: Mesos Reviewbot Windows References: <20170609183610.7068.28322@reviews-vm2.apache.org> In-Reply-To: <20170609183610.7068.28322@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============0999759703590995039== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/#review177510 ----------------------------------------------------------- Patch looks great! Reviews applied: [59949, 59950] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On June 9, 2017, 6:36 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59950/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 6:36 p.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-7631 > https://issues.apache.org/jira/browse/MESOS-7631 > > > Repository: mesos > > > Description > ------- > > Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`. > > > Diffs > ----- > > src/tests/containerizer/cni_isolator_tests.cpp 565e58ae75e918453e4386f5e35a5a844a8b15f8 > > > Diff: https://reviews.apache.org/r/59950/diff/1/ > > > Testing > ------- > > make check > > [==========] Running 2 tests from 2 test cases. > [----------] Global test environment set-up. > [----------] 1 test from HostNetwork/DefaultExecutorCniTest > [ RUN ] HostNetwork/DefaultExecutorCniTest.ROOT_VerifyContainerIP/0 > I0609 18:16:12.417310 22692 executor.cpp:192] Version: 1.4.0 > I0609 18:16:12.435683 22694 default_executor.cpp:182] Received SUBSCRIBED event > I0609 18:16:12.441695 22694 default_executor.cpp:186] Subscribed executor on centos7 > I0609 18:16:12.442006 22694 default_executor.cpp:182] Received LAUNCH_GROUP event > W0609 18:16:12.444447 22691 default_executor.cpp:443] Setting `MESOS_CONTAINER_IP` to: 127.0.0.1 > I0609 18:16:12.469161 22691 default_executor.cpp:605] Successfully launched tasks [ 34ddb6bc-bf93-42ff-aab1-cb06d25c5fc6 ] in child containers [ 1a6e3ada-7e68-43c7-95e2-88978c055c7d.1f0a6c53-8189-4989-8dd1-4e38f28f7f5e ] > I0609 18:16:12.472266 22693 default_executor.cpp:678] Waiting for child container 1a6e3ada-7e68-43c7-95e2-88978c055c7d.1f0a6c53-8189-4989-8dd1-4e38f28f7f5e of task '34ddb6bc-bf93-42ff-aab1-cb06d25c5fc6' > I0609 18:16:12.481412 22689 default_executor.cpp:182] Received ACKNOWLEDGED event > I0609 18:16:12.575834 22694 default_executor.cpp:823] Child container 1a6e3ada-7e68-43c7-95e2-88978c055c7d.1f0a6c53-8189-4989-8dd1-4e38f28f7f5e of task '34ddb6bc-bf93-42ff-aab1-cb06d25c5fc6' in state TASK_FINISHED exited with status 0 > I0609 18:16:12.575960 22694 default_executor.cpp:945] Terminating after 1secs > [ OK ] HostNetwork/DefaultExecutorCniTest.ROOT_VerifyContainerIP/0 (2366 ms) > [----------] 1 test from HostNetwork/DefaultExecutorCniTest (2368 ms total) > > [----------] 1 test from CniNetwork/DefaultExecutorCniTest > [ RUN ] CniNetwork/DefaultExecutorCniTest.ROOT_VerifyContainerIP/0 > I0609 18:16:13.042444 22763 executor.cpp:192] Version: 1.4.0 > I0609 18:16:13.059947 22759 default_executor.cpp:182] Received SUBSCRIBED event > I0609 18:16:13.065265 22759 default_executor.cpp:186] Subscribed executor on centos7 > I0609 18:16:13.065783 22759 default_executor.cpp:182] Received LAUNCH_GROUP event > W0609 18:16:13.067163 22763 default_executor.cpp:443] Setting `MESOS_CONTAINER_IP` to: 10.0.2.15 > I0609 18:16:13.181131 22765 default_executor.cpp:605] Successfully launched tasks [ 1d265a47-6422-458e-b350-9a1091130c40 ] in child containers [ 48fc4118-8637-4564-9a8f-73de5712e277.69464142-e313-4c8e-859c-cd1d2cce4e26 ] > I0609 18:16:13.183614 22764 default_executor.cpp:678] Waiting for child container 48fc4118-8637-4564-9a8f-73de5712e277.69464142-e313-4c8e-859c-cd1d2cce4e26 of task '1d265a47-6422-458e-b350-9a1091130c40' > I0609 18:16:13.191012 22760 default_executor.cpp:182] Received ACKNOWLEDGED event > I0609 18:16:13.290139 22763 default_executor.cpp:823] Child container 48fc4118-8637-4564-9a8f-73de5712e277.69464142-e313-4c8e-859c-cd1d2cce4e26 of task '1d265a47-6422-458e-b350-9a1091130c40' in state TASK_FINISHED exited with status 0 > I0609 18:16:13.290249 22763 default_executor.cpp:945] Terminating after 1secs > [ OK ] CniNetwork/DefaultExecutorCniTest.ROOT_VerifyContainerIP/0 (728 ms) > [----------] 1 test from CniNetwork/DefaultExecutorCniTest (729 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 2 test cases ran. (3105 ms total) > [ PASSED ] 2 tests. > > > Thanks, > > Avinash sridharan > > --===============0999759703590995039==--