From reviews-return-61803-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jun 9 04:27:14 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3FED21ADEF for ; Fri, 9 Jun 2017 04:27:14 +0000 (UTC) Received: (qmail 25932 invoked by uid 500); 9 Jun 2017 04:27:14 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 25903 invoked by uid 500); 9 Jun 2017 04:27:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 25887 invoked by uid 99); 9 Jun 2017 04:27:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jun 2017 04:27:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 455C1C090E; Fri, 9 Jun 2017 04:27:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id dOEhCyq-1CwQ; Fri, 9 Jun 2017 04:27:12 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D13305F6CD; Fri, 9 Jun 2017 04:27:11 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7534DE00A7; Fri, 9 Jun 2017 04:27:11 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BC4BBC40030; Fri, 9 Jun 2017 04:27:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7182179096116291571==" MIME-Version: 1.0 Subject: Re: Review Request 56895: Allow agents to recover slave state post a reboot. From: Megha Sharma To: Neil Conway , Vinod Kone , Jiang Yan Xu Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Megha Sharma , mesos Date: Fri, 09 Jun 2017 04:27:09 -0000 Message-ID: <20170609042709.1778.99434@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Megha Sharma X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56895/ X-Sender: Megha Sharma References: <20170516231746.64283.58564@reviews-vm2.apache.org> In-Reply-To: <20170516231746.64283.58564@reviews-vm2.apache.org> Reply-To: Megha Sharma X-ReviewRequest-Repository: mesos --===============7182179096116291571== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ ----------------------------------------------------------- (Updated June 9, 2017, 4:27 a.m.) Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-6223 https://issues.apache.org/jira/browse/MESOS-6223 Repository: mesos Description ------- With partition awareness, the agents are now allowed to re-register after they have been marked Unreachable. The executors are anyway terminated on the agent when it reboots so there is no harm in letting the agent keep its SlaveID, re-register with the master and reconcile the lost executors. This is a pre-requisite for supporting persistent/restartable tasks in mesos. Diffs (updated) ----- src/slave/containerizer/composing.cpp a003e1b80dc9b4dec5b3fbbadb2daecf855c90c7 src/slave/containerizer/docker.cpp 9f84109d7de22a39ace6e44e0c7d8d501bcb24de src/slave/containerizer/mesos/containerizer.cpp f3e6210eccd4a6b445ffd4447e69526d424ea36d src/slave/slave.hpp 7ffaed14035a05259ec72c70532ee4f0affa1f5d src/slave/slave.cpp 7d147ac6609933ac884bfc29032dba572a0952c6 src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5 src/slave/state.cpp 18b790d2cc4f537cc9b0c3cca59b9cbaac0eda10 src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c Diff: https://reviews.apache.org/r/56895/diff/7/ Changes: https://reviews.apache.org/r/56895/diff/6-7/ Testing ------- make check Thanks, Megha Sharma --===============7182179096116291571==--