mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.
Date Thu, 29 Jun 2017 15:23:54 GMT


> On June 29, 2017, 9:48 a.m., Benjamin Mahler wrote:
> > Thanks Andrei, the code looks good. Can you split the test out? That way I can give
a ship it on the code change, while we continue working on the test.

https://reviews.apache.org/r/60539/


> On June 29, 2017, 9:48 a.m., Benjamin Mahler wrote:
> > src/slave/http.cpp
> > Lines 1326 (patched)
> > <https://reviews.apache.org/r/60369/diff/3/?file=1766140#file1766140line1326>
> >
> >     How about a TODO here?
> >     
> >     TODO(abudnik): Consider storing the allocatedResources in the Slave struct rather
than computing it here each time.

Added.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179240
-----------------------------------------------------------


On June 29, 2017, 3:23 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
> 
> (Updated June 29, 2017, 3:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
>     https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message