mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60529: Fixed support/apply-reviews.py.
Date Thu, 29 Jun 2017 08:34:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60529/#review179236
-----------------------------------------------------------


Fix it, then Ship it!





support/apply-reviews.py
Line 189 (original), 189 (patched)
<https://reviews.apache.org/r/60529/#comment253884>

    Why call this url? It's the response FWICT.


- Benjamin Mahler


On June 29, 2017, 8:26 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60529/
> -----------------------------------------------------------
> 
> (Updated June 29, 2017, 8:26 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While cleaning up this script for PyLint conformance in
> 09fc35978c77ed0f22df1823f5c9220f1ed098ed we introduced usage of an
> incorrect value `patch` when this script was run under Windows.
> 
> This commit restores the previous data flow. The issue was the cause
> of the Mesos Reviewbot Windows error messages seen when review
> requests were posted on the Review Board the past few days.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py c9c87c6fce4e125a664307f7ac8bc56f4919f157 
> 
> 
> Diff: https://reviews.apache.org/r/60529/diff/2/
> 
> 
> Testing
> -------
> 
> Added support to source_dirs in the PyLinter defined in 
> mesos-style.py. Only acceptable errors where displayed (e.g. due 
> to the name of the file containing a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message