mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60529: Fixed support/apply-reviews.py.
Date Thu, 29 Jun 2017 08:02:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60529/#review179234
-----------------------------------------------------------


Ship it!




Could you make the commit description more explicit, and e.g., call out what broke this in
the first place, e.g.,

    Fixed support/apply-reviews.py.
    
    While cleaning up this script for pylint-conformance in
    09fc35978c77ed0f22df1823f5c9220f1ed098ed we introduced usage of an
    incorrect value when this script was run under Windows.

    This commit restores the previous data flow.

- Benjamin Bannier


On June 29, 2017, 9:44 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60529/
> -----------------------------------------------------------
> 
> (Updated June 29, 2017, 9:44 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The variable `patch` is not overwritten anymore. This patch fixes
> the Mesos Reviewbot Windows error messages seen recently on the
> Review Board.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py c9c87c6fce4e125a664307f7ac8bc56f4919f157 
> 
> 
> Diff: https://reviews.apache.org/r/60529/diff/1/
> 
> 
> Testing
> -------
> 
> Added support to source_dirs in the PyLinter defined
> in mesos-style.py. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message