-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179184
-----------------------------------------------------------
src/common/http.hpp
Lines 40-42 (patched)
<https://reviews.apache.org/r/60107/#comment253757>
We always fully qualify all namespaces in headers (i.e., no `using` statements). It will
make some of the lines really long, but that's OK.
- Greg Mann
On June 28, 2017, 9:38 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 9:38 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added filtering to the '/tasks' endpoint.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e
> src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6
> src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67
> src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea
>
>
> Diff: https://reviews.apache.org/r/60107/diff/6/
>
>
> Testing
> -------
>
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000
--gtest_break_on_failure"
>
>
> Thanks,
>
> Quinn Leng
>
>
|