mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Re: Review Request 60107: Finished object acceptor for tasks endpoint.
Date Wed, 28 Jun 2017 21:35:51 GMT


> On June 28, 2017, 7:05 p.m., Greg Mann wrote:
> > src/common/http.hpp
> > Lines 205-218 (patched)
> > <https://reviews.apache.org/r/60107/diff/5/?file=1764406#file1764406line205>
> >
> >     It doesn't look like this class is used at all in this patch, can we remove
it?

I am creating AuthorizeAcceptors according to these functions "approveViewXXX()", it seems
that the TaskInfo function is not used in the endpoint handler. I'll remvoe it.


> On June 28, 2017, 7:05 p.m., Greg Mann wrote:
> > src/common/http.hpp
> > Lines 228-229 (patched)
> > <https://reviews.apache.org/r/60107/diff/5/?file=1764406#file1764406line228>
> >
> >     Should break after parentheses:
> >     
> >     ```
> >     bool accept(
> >         const Task& task,
> >     ```

Even if there are only two parameters?


- Quinn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179132
-----------------------------------------------------------


On June 27, 2017, 10:30 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 10:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Finished object acceptor for "/tasks" endpoint.
> 
> Added the query parameter support for that endpoint.
> To query a task, you have to specify both framework_id
> and task_id. Thus the query would look like
> "/tasks?framework_id=[framework id];task_id=[task id]"
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/5/
> 
> 
> Testing
> -------
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000
--gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message