mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 59937: Added agent `--resource_provider_config_dir` flag.
Date Wed, 28 Jun 2017 14:08:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59937/#review179100
-----------------------------------------------------------




docs/configuration.md
Lines 1900 (patched)
<https://reviews.apache.org/r/59937/#comment253567>

    ... representing _a_ ...



docs/configuration.md
Lines 1903 (patched)
<https://reviews.apache.org/r/59937/#comment253568>

    ... handling operations _on_ the resources ...



docs/configuration.md
Lines 1907-1908 (patched)
<https://reviews.apache.org/r/59937/#comment253569>

    Could we call out why we do not expose `resources` here? I imagine this is due to us wanted
to determine them automatically on RP startup? To call it out here instead of e.g., the proto
definition probably does make sense, since the proto definition could be used differently
in different contexts.



src/slave/flags.cpp
Lines 98-109 (patched)
<https://reviews.apache.org/r/59937/#comment253570>

    See comments in `configuration.md`.


- Benjamin Bannier


On June 26, 2017, 6:31 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59937/
> -----------------------------------------------------------
> 
> (Updated June 26, 2017, 6:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7571
>     https://issues.apache.org/jira/browse/MESOS-7571
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent `--resource_provider_config_dir` flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 0eb696a949003ff11831aed5e4f4ab384cf9992e 
>   src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
>   src/slave/flags.cpp c84aa6724170bba46b4444be8410b71d42a1626e 
> 
> 
> Diff: https://reviews.apache.org/r/59937/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message