mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.
Date Wed, 28 Jun 2017 12:08:57 GMT


> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/slave/http.cpp
> > Lines 1334-1344 (patched)
> > <https://reviews.apache.org/r/60369/diff/2/?file=1764200#file1764200line1334>
> >
> >     Should we follow this pattern?
> >     
> >     
> >     ```
> >             writer->field(
> >                 "reserved_resources_full",
> >                 [&totalResources](JSON::ObjectWriter* writer) {
> >                   foreachpair (const string& role,
> >                                const Resources& resources,
> >                                totalResources.reservations()) {
> >     
> >     ```

Yeah, sure. Fixed.


> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/slave/http.cpp
> > Lines 1344 (patched)
> > <https://reviews.apache.org/r/60369/diff/2/?file=1764200#file1764200line1344>
> >
> >     Nit: Add one blank line below.

Fixed.


> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/tests/reservation_endpoints_tests.cpp
> > Line 1739 (original), 1739 (patched)
> > <https://reviews.apache.org/r/60369/diff/2/?file=1764201#file1764201line1739>
> >
> >     Nit: Add one blank line below.

Fixed.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179000
-----------------------------------------------------------


On June 28, 2017, 12:08 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 12:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
>     https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
>   src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5

> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message