-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60170/#review179051
-----------------------------------------------------------
For some isolators that depend on some specific cgroup isolator (e.g., gpu isolator), please
update the code accordingly.
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 116-117 (patched)
<https://reviews.apache.org/r/60170/#comment253455>
This logic is indeed very weird! I think the right approach is to make perf sampling a
separate isolator that depends on cgroups perf_event subsystem being enabled (similar to gpu
isolator depends on cgroups devices isolator).
The cgroups perf_event will simply just create the cgroup, but not performing sampling.
- Jie Yu
On June 26, 2017, 10:39 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60170/
> -----------------------------------------------------------
>
> (Updated June 26, 2017, 10:39 p.m.)
>
>
> Review request for mesos, haosdent huang, Hao Yixin, Jason Lai, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduced a new agent isolation option 'cgroups', which
> represents all local machine supported cgroup subsystems will be
> turned on automatically.
>
> Note that if this 'cgroups' option is specified in isolation, all
> other specified cgroup subsystems will be included.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp d7a95b2d49fd2ae743e2bffc25f15c4ce4b96f39
>
>
> Diff: https://reviews.apache.org/r/60170/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
|