mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.
Date Tue, 27 Jun 2017 19:52:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/#review179028
-----------------------------------------------------------



Great idea, AFAICT this does what we want and is much simpler.


support/hooks/commit-msg
Lines 18 (patched)
<https://reviews.apache.org/r/60216/#comment253429>

    Could you make sure we only match at the beginning of the string, something like
    
       if [[ "$FIRST_LINE" =~ ^(fixup|squash)! ]]; then
       
    Note that I added some escaping here to deal with history expansion, could you please
confirm that this is reasonable?


- Benjamin Bannier


On June 27, 2017, 9:41 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60216/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 9:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4331
>     https://issues.apache.org/jira/browse/MESOS-4331
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The capitalization check caused rebases to fail for commits made with
> `--fixup` and `--squash`. This change ignores the check for these cases.
> 
> 
> Diffs
> -----
> 
>   support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 
> 
> 
> Diff: https://reviews.apache.org/r/60216/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message