mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Zhuk <dz...@twopensource.com>
Subject Review Request 60473: WIP: Allowed use of mutable properties in protobuf message handlers.
Date Tue, 27 Jun 2017 17:33:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60473/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-6972
    https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
-------

Currently installing protobuf message handlers requires const accessors to message properties.
This limits returned values usage to read-only, e.g. if this value needs to be stored somewhere,
then a copy should be made. This patch allows specifying non-const accessors as well to provide
read-write access to message properties, specifically to allow moving them into storage.


Diffs
-----

  3rdparty/libprocess/include/process/protobuf.hpp ba6e6d6504250a2609b336f3e9854cfbe5da52ec



Diff: https://reviews.apache.org/r/60473/diff/1/


Testing
-------

make check


Thanks,

Dmitry Zhuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message