mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.
Date Tue, 27 Jun 2017 17:25:36 GMT


> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 176 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line176>
> >
> >     Should we use `*` here to keep consistent with other parts?
> 
> Andrei Budnik wrote:
>     There is related discussion in the ticket, so it looks like we have agreed on calling
it "Unreserved".

> it looks like we have agreed on calling it "Unreserved".

It would be great that could post the link to that comment here.


> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line184>
> >
> >     Is `|| 0` necessary here?
> 
> Andrei Budnik wrote:
>     I think yes, because we might miss information about a specific role in state.reserved_resources_allocated.
E.g., we have both statically reserved resources for both "ads" and "dyn" roles, but only
one role is actually allocated. Let's assume that resources from "dyn" role are used to launch
some task, while "ads" role isn't used, hence no item for "ads" in state.reserved_resources_allocated
exists. In the latter case 0 is used as a default value.

Hmm, but

```
state.unreserved_resources_allocated.cpus | number
```

above would show `/0` as well.

Should we keep consistency since almost part use this pattern

```
          <td>{{monitor.frameworks[framework.id].statistics.cpus_total_usage | number}}
/ {{framework.cpus | number}}</td>
```


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178801
-----------------------------------------------------------


On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 5:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
>     https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 67bfd030649dd21840c16188a4964f814aa232d7

> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/2/
> 
> 
> Testing
> -------
> 
> See screenshot.
> 
> 
> File Attachments
> ----------------
> 
> agent.html
>   https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message