mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Review Request 60407: Avoided master crash on agent re-registration.
Date Sat, 24 Jun 2017 00:28:39 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Michael Park.

Repository: mesos


When validating the agent's ReregisterSlaveMessage, the master's
validation code neglected to account for the fact that the task
resources might not be in post-refinement format (e.g., if the agent
does not support reservation refinement). This lead to a `CHECK` failure
during validation.

Fix this by relaxing the validation of ReregisterSlaveMessage so that we
do not depend on the task resources being in post-refinement
format. This means validation of ReregisterSlaveMessage will be less
effective, but since it is best-effort anyway, this seems tolerable.


  src/master/validation.cpp 33e9ff7db9e2789cbb2d6dfd015288dfa1faa7c5 



`make check`


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message