mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60351: Updated the `operator<<` for repeated resources to use `JSON::protobuf`.
Date Thu, 22 Jun 2017 22:40:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60351/#review178758
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On June 22, 2017, 12:08 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60351/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 12:08 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `Resource` objects in a `RepeatedPtrField<Resource>` may not be
> validated and/or not converted to the "post-reservation-refinement"
> format. Since `Resources` requires the resources to have been validated
> and converted, we cannot rely on the conversion to be meaningful.
> We opt to print the resources in their JSON representation instead.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 1d9170a9836799cf3764fbb37cd2e2aebd3e75b3 
>   src/v1/resources.cpp 58a00e933ad16481d3bdec6e273154ea93221830 
> 
> 
> Diff: https://reviews.apache.org/r/60351/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message