mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60283: Fixed `convertResourceFormat` uses with `validateAndUpgradeResources`.
Date Thu, 22 Jun 2017 22:22:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60283/
-----------------------------------------------------------

(Updated June 22, 2017, 3:22 p.m.)


Review request for mesos and Neil Conway.


Changes
-------

Addressed comments.


Repository: mesos


Description
-------

Initially, it seemed like calling `convertResourceFormat` after
operation validation seemed safe since the operation validation
themselves performed `Resources::validate` within them.

However, the rest of the operation validation code relies on
the fact that the resources have been validated, and uses
functions such as `isDynamicallyReserved`. Since functions such as
`isDynamicallyReserved` now requires "post-reservation-refinement"
format, we must perform this conversion earlier.

In this patch, we use `upgradeResources` to perform resources
validation __and__ convert the resources before going into the
operation and task validation.

We really need a better plan for this going forward. MESOS-7702.


Diffs (updated)
-----

  src/master/master.cpp b0818e1e59ce9804cd9592aa2a7ec8f80ba5bddf 
  src/tests/master_tests.cpp 652f37ab6f640ac87c48e419680501b705e11394 
  src/tests/resource_offers_tests.cpp c2bbf834c1d46079af492887b9dd40e57f3f2ac7 


Diff: https://reviews.apache.org/r/60283/diff/9/

Changes: https://reviews.apache.org/r/60283/diff/8-9/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message