mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60255: Prevented reserve/create with refined reservation on non-capable agents.
Date Thu, 22 Jun 2017 22:07:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60255/#review178751
-----------------------------------------------------------


Ship it!




We can do this later, but would be nice to have unit tests for this -- similar to `CreateOperationValidationTest.AgentHierarchicalRoleCapability`

- Neil Conway


On June 20, 2017, 11:58 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60255/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 11:58 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7700
>     https://issues.apache.org/jira/browse/MESOS-7700
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes it such that reserve / create operations involving
> resources with refined reservations are invalid if they are attempted
> on an agent without a RESERVATION_REFINEMENT capability. Such attempts
> from an operator endpoint will result in a `BadRequest` response.
> On the framework side, the operation will be dropped by the master.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 4d0af26fedb6ef3039536cb42d2ac9112c9f4bdd 
> 
> 
> Diff: https://reviews.apache.org/r/60255/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message