-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60281/#review178740
-----------------------------------------------------------
src/master/master.cpp
Line 4483 (original), 4483 (patched)
<https://reviews.apache.org/r/60281/#comment252901>
This comment needs updating.
- Neil Conway
On June 21, 2017, 7:06 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60281/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 7:06 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we drop invalid tasks on a `LAUNCH` operation, we send a new
> `Operation` with only the valid tasks appended. At the same time,
> we adjust the `TaskInfo` a little bit to perform validation, and
> to maintain backwards compatibility. However, the unmodified
> `TaskInfo` was sent to the allocator. Since the allocator does not
> look at the modified fields, this was inconsequential, but we should
> avoid sending inconsistent `TaskInfo`s in general.
>
> We also avoided creating an unnecessary copy of the `TaskInfo`.
>
>
> Diffs
> -----
>
> src/master/master.cpp ec594a8f4fa95e77fc38103c5561d1797fe2b133
>
>
> Diff: https://reviews.apache.org/r/60281/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
|