mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60374: Required that resources are always downgraded for a non-capable agent.
Date Thu, 22 Jun 2017 20:43:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60374/#review178737
-----------------------------------------------------------




src/master/master.cpp
Line 4919 (original), 4907 (patched)
<https://reviews.apache.org/r/60374/#comment252897>

    Can we add a comment explaining why these are `CHECK`s?


- Neil Conway


On June 22, 2017, 7:09 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60374/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 7:09 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7575
>     https://issues.apache.org/jira/browse/MESOS-7575
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the master prevents refined reservations from being created on
> non-capable agents, we cannot be in a situation in which the resources
> are not downgradable for a non-capable agent.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp ec594a8f4fa95e77fc38103c5561d1797fe2b133 
> 
> 
> Diff: https://reviews.apache.org/r/60374/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message