-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60283/#review178707
-----------------------------------------------------------
src/master/master.cpp
Line 4680 (original), 4698 (patched)
<https://reviews.apache.org/r/60283/#comment252862>
Not in this RR, but this seems dubious to me: if we're not able to launch a task with
refined reservations on an old agent, we skip sending `RunTaskMessage` but we _do_ add the
task to `operations`, which is later passed to the allocator. Seems wrong.
Also, do we have a test case for this situation?
src/master/master.cpp
Lines 4754 (patched)
<https://reviews.apache.org/r/60283/#comment252863>
I wonder if we want `validateAndUpgradeResources` of a `TaskInfo`.
src/tests/master_tests.cpp
Lines 7200 (patched)
<https://reviews.apache.org/r/60283/#comment252856>
Whitespace.
src/tests/master_tests.cpp
Lines 7202 (patched)
<https://reviews.apache.org/r/60283/#comment252857>
Can we remove this? Seems irrelevant to the test's purpose.
- Neil Conway
On June 21, 2017, 7:08 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60283/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 7:08 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Initially, it seemed like calling `convertResourceFormat` after
> operation validation seemed safe since the operation validation
> themselves performed `Resources::validate` within them.
>
> However, the rest of the operation validation code relies on
> the fact that the resources have been validated, and uses
> functions such as `isDynamicallyReserved`. Since functions such as
> `isDynamicallyReserved` now requires "post-reservation-refinement"
> format, we must perform this conversion earlier.
>
> In this patch, we use `upgradeResources` to perform resources
> validation __and__ convert the resources before going into the
> operation and task validation.
>
> We really need a better plan for this going forward. MESOS-7702.
>
>
> Diffs
> -----
>
> src/master/master.cpp ec594a8f4fa95e77fc38103c5561d1797fe2b133
> src/tests/master_tests.cpp 652f37ab6f640ac87c48e419680501b705e11394
> src/tests/resource_offers_tests.cpp c2bbf834c1d46079af492887b9dd40e57f3f2ac7
>
>
> Diff: https://reviews.apache.org/r/60283/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
|