mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 60280: Provide full path to the custom executor.
Date Thu, 22 Jun 2017 15:19:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60280/
-----------------------------------------------------------

(Updated June 22, 2017, 3:19 p.m.)


Review request for mesos, Jie Yu, James Peach, and Zhitao Li.


Bugs: MESOS-7703
    https://issues.apache.org/jira/browse/MESOS-7703


Repository: mesos


Description
-------

If a framework specifies use of its own executor and sets shell to false the executor is never
found. Additionally, the name of the binary is never passed as an argument so executors making
use of argv[0] will fail. This provides the full path to the executor so that the `execvp`
or `execvpe` is successful. The name of the binary is also passed as the first argument for
cases where there is no shell used.


Diffs (updated)
-----

  src/slave/containerizer/mesos/launch.cpp 162ca1c2e 


Diff: https://reviews.apache.org/r/60280/diff/3/

Changes: https://reviews.apache.org/r/60280/diff/2-3/


Testing
-------

`cd build && cmake .. -DCMAKE_BUILD_TYPE=Release && make -j4`
Also spun up a master and agent, connected and sent a task using the UCR (both with and without
the use of an OCI image) via our own framework, and checked the sandbox to verify that things
went accordingly.


Thanks,

Aaron Wood


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message