-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review178668
-----------------------------------------------------------
Also, I don't know if calling it a filter is the right thing to do. A filter should recieve
a data set and remove things from it. This abstraction can only verify one element at a time,
therefore it is not a filter. Acceptor would be a better name for it.
- Alexander Rojas
On June 20, 2017, 2:30 a.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 2:30 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add class definition for ObjectFilter.
>
>
> Diffs
> -----
>
> src/common/http.hpp 48f7c4a9c35371544c92bb1712e1e354feb20987
> src/common/http.cpp 98899a789610add924a7d2c0af943230cf914d2d
>
>
> Diff: https://reviews.apache.org/r/60107/diff/4/
>
>
> Testing
> -------
>
> Passed "make check"
> No specific test case related
>
>
> Thanks,
>
> Quinn Leng
>
>
|